Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip malware-detection tests on RHEL6/python2.6 (not supported) #3382

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

mhuth
Copy link
Contributor

@mhuth mhuth commented Apr 12, 2022

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

This is to correct problems encountered when running the malware-detection tests on RHEL6 systems outside the automated PR check environment. Malware detection won't be supported on RHEL6 so no need to check it works in that environment anyway.

@mhuth mhuth requested review from Glutexo and bfahr April 12, 2022 05:39
Copy link
Contributor

@bfahr bfahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @Glutexo I'll wait until you review before merging.

@Glutexo
Copy link
Collaborator

Glutexo commented Apr 21, 2022

Although Python 2.6 / RHEL 6 is not supported, adding support here is very easy. But the original problem with the tests is that it uses an external utility and is dependent on an actual state of the machine.

@bfahr bfahr merged commit b8ca616 into master Apr 21, 2022
bfahr pushed a commit that referenced this pull request Apr 21, 2022
@Glutexo Glutexo deleted the skip_malware_detection_tests_rhel6 branch April 22, 2022 10:22
xiangce pushed a commit that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants